[PATCH] USB: gadget: at91_udc: fix usb_ep_set_maxpacket_limit() usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In commit e117e742 (usb: gadget: add "maxpacket_limit" field to
struct usb_ep) usb_ep_set_maxpacket_limit() function was used incorrectly
in at91udc_probe() function, when maxpacket value should be set to
instances of struct at91_ep, not struct usb_ep.

This patch fix this by reverting original code.

Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
---

Hello,

This patch is reply for problem discussed here:
http://www.spinics.net/lists/linux-usb/msg100241.html

Best regards
Robert Baldyga
Samsung R&D Institute Poland

 drivers/usb/gadget/at91_udc.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index 0353b64..dc7a7c2 100644
--- a/drivers/usb/gadget/at91_udc.c
+++ b/drivers/usb/gadget/at91_udc.c
@@ -1759,15 +1759,15 @@ static int at91udc_probe(struct platform_device *pdev)
 
 	/* newer chips have more FIFO memory than rm9200 */
 	if (cpu_is_at91sam9260() || cpu_is_at91sam9g20()) {
-		usb_ep_set_maxpacket_limit(&udc->ep[0], 64);
-		usb_ep_set_maxpacket_limit(&udc->ep[3], 64);
-		usb_ep_set_maxpacket_limit(&udc->ep[4], 512);
-		usb_ep_set_maxpacket_limit(&udc->ep[5], 512);
+		udc->ep[0].maxpacket = 64;
+		udc->ep[3].maxpacket = 64;
+		udc->ep[4].maxpacket = 512;
+		udc->ep[5].maxpacket = 512;
 	} else if (cpu_is_at91sam9261() || cpu_is_at91sam9g10()) {
-		usb_ep_set_maxpacket_limit(&udc->ep[3], 64);
+		udc->ep[3].maxpacket = 64;
 	} else if (cpu_is_at91sam9263()) {
-		usb_ep_set_maxpacket_limit(&udc->ep[0], 64);
-		usb_ep_set_maxpacket_limit(&udc->ep[3], 64);
+		udc->ep[0].maxpacket = 64;
+		udc->ep[3].maxpacket = 64;
 	}
 
 	udc->udp_baseaddr = ioremap(res->start, resource_size(res));
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux