Re: [PATCH 2/2] USB: c67x00: add proper delays to HPI read/write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "Max" == Max Filippov <jcmvbkbc@xxxxxxxxx> writes:

 > According to CY7C67300 specification HPI read and write cycle duration
 > Tcyc must be at least 6T long, where T is 1/48MHz, which is 125ns.
 > Without this delay fast host processor cannot write to chip registers.
 > Add proper ndelay to hpi_{read,write}_reg.

It would be good to add a sensible named define (with the above
description) as a comment and use that instead of the magic 125 constant
in the code.

With that fixed:

Acked-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux