Hi Linus, On Wed, Oct 16, 2019 at 02:27:44PM +0200, Linus Walleij wrote: > On Tue, Oct 15, 2019 at 7:30 PM Manivannan Sadhasivam > <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > > Add YAML devicetree binding for RDA Micro GPIO controller. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > First: this looks awesome to me, > > Second: since this is kind of a first... could we move the standard GPIOchip > YAML business into a generic gpiochip .yaml file? > > We currently only have pl061-gpio.yaml and this would duplicate a lot > of the stuff from that yaml file. > > If you look at how > display/panel/panel-common.yaml > is used from say > display/panel/ti,nspire.yaml > > Could we do something similar and lift out all the generics from > gpio-pl061.yaml to > gpio-common.yaml > and reference that also in the new binding? > > If it seems hard, tell me and I can take a stab at it. > Eventhough I really want to help you here, I'm running out of time (and you know why). Let's consider merging this, and I'll come back at it later. Thanks, Mani > Yours, > Linus Walleij _______________________________________________ linux-unisoc mailing list linux-unisoc@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-unisoc
