On Sat, Oct 26, 2024 at 08:30:54AM +0200, Amir Goldstein wrote: > On Fri, Oct 25, 2024 at 5:02 PM Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote: > > > > The reason for the dget/dput pair was to force the upperdentry to be > > dropped from the cache instead of turning it negative and keeping it > > cached. > > > > Simpler and cleaner way to achieve the same effect is to just drop the > > dentry after unlink/rmdir if it was turned negative. > > > > Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxxxxx> > > Looks sane. > Applied to overlayfs-next for testing. I thought it was about preventing an overlayfs objects with negative ->__upperdentry; why would a negative dentry in upper layer be a problem otherwise?