On Tue, 15 Oct 2024 at 20:57, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > But I think that if we aim for a cleaner interface then the arguments of > backing_file_splice_{read,write}() should be similar and so should the > arguments of ->{end_write,access}(), so we should change > ->access(file *) to ->end_read(iocb *) Changing ->access() to iocb would mean having to manufature an iocb for mmap(), which would be unnatural. So I didn't touch that. Thanks, Miklos