On Thu, 29 Aug 2024 at 12:29, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > But maybe we can ignore crash safety of metacopy on ubifs, because > 1. the ubifs users may not be using this feature > 2. ubifs may be nice and takes care of ordering O_TMPFILE > metadata updates before exposing the link > > Then we can do the following: > IF (metacopy_enabled) > fsync only in ovl_copy_up_file() > ELSE > fsync only in ovl_copy_up_metadata() > > Let me know what you think. Sounds like a good compromise. Thanks, Miklos
