On Thu, Aug 29, 2024 at 3:25 AM Hongbo Li <lihongbo22@xxxxxxxxxx> wrote: > > > > On 2024/8/28 23:17, Amir Goldstein wrote: > > On Wed, Aug 28, 2024 at 1:57 PM Hongbo Li <lihongbo22@xxxxxxxxxx> wrote: > >> > >> The sb->s_magic holds the file system magic, we can use > >> this to avoid use file system magic macro directly. > > > > That we can do something, does not mean that we need to do it. > > I don't see any benefit in this patch. > > Please explain. > Just avoid using the macro directly. > > This kind of macro definition is like a magic number; once it changes, > it will affect a large amount of code. > As long as sb->s_magic is initialized in exactly the same way, this argument is moot IMO. If there comes a time where sb->s_magic would be filled from persistent storage then this code would make sense. Thanks, Amir.
