Re: [PATCH v3 3/3] ovl: ovl_parse_param_lowerdir: Add missed '\n' for pr_err

[Amir Goldstein <amir73il@xxxxxxxxx>]

On Fri, Jul 5, 2024 at 3:17 AM Zhihao Cheng <chengzhihao1@xxxxxxxxxx> wrote:
>
> Add '\n' for pr_err in function ovl_parse_param_lowerdir(), which
> ensures that error message is displayed at once.
>
> Fixes: b36a5780cb44 ("ovl: modify layer parameter parsing")
> Signed-off-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>
> ---
>  fs/overlayfs/params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c
> index 8dd834c7f291..657da705db25 100644
> --- a/fs/overlayfs/params.c
> +++ b/fs/overlayfs/params.c
> @@ -493,7 +493,7 @@ static int ovl_parse_param_lowerdir(const char *name, struct fs_context *fc)
>                          * there are no data layers.
>                          */
>                         if (ctx->nr_data > 0) {
> -                               pr_err("regular lower layers cannot follow data lower layers");
> +                               pr_err("regular lower layers cannot follow data lower layers\n");
>                                 goto out_err;
>                         }
>
> --
> 2.39.2
>

Christian,

Would you mind picking up this series via vfs tree?

While at at could also fix this missed spot:

--- a/fs/overlayfs/params.c
+++ b/fs/overlayfs/params.c
@@ -449,7 +449,7 @@ static int ovl_parse_param_lowerdir(const char
*name, struct fs_context *fc)
                return 0;

        if (*name == ':') {
-               pr_err("cannot append lower layer");
+               pr_err("cannot append lower layer\n");
                return -EINVAL;
        }

Thanks,
Amir.