On Mon, Jul 29, 2024 at 6:43 AM Haifeng Xu <haifeng.xu@xxxxxxxxxx> wrote:
>
> Since commit 5679897eb104 ("vfs: make sync_filesystem return errors from
> ->sync_fs"), the return value from sync_fs callback can be seen in
> sync_filesystem(). Thus the errseq_set opreation can be removed here.
>
> Signed-off-by: Haifeng Xu <haifeng.xu@xxxxxxxxxx>
I would add either Fixes: or Depends-on: to prevent accidental
backporting without the dependency.
Otherwise you may add:
Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>
Thanks,
Amir.
> ---
> fs/overlayfs/super.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index 06a231970cb5..fe511192f83c 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -202,15 +202,9 @@ static int ovl_sync_fs(struct super_block *sb, int wait)
> int ret;
>
> ret = ovl_sync_status(ofs);
> - /*
> - * We have to always set the err, because the return value isn't
> - * checked in syncfs, and instead indirectly return an error via
> - * the sb's writeback errseq, which VFS inspects after this call.
> - */
> - if (ret < 0) {
> - errseq_set(&sb->s_wb_err, -EIO);
> +
> + if (ret < 0)
> return -EIO;
> - }
>
> if (!ret)
> return ret;
> --
> 2.25.1
>
