Re: crash inside ovl_encode_real_fh() due to NULL dentry pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thank you Miklos. I tested the patch, it works.

On Thu, Jun 13, 2024 at 5:01 AM Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
> On Thu, 13 Jun 2024 at 03:32, Youzhong Yang <youzhong@xxxxxxxxx> wrote:
> > I analyzed the crash dump, here is what I figured out:
> > - The overlay fs is mounted with only 2 lowerdirs, and nfs_export=on
> > - When ovl_dentry_to_fid() is called on the root dentry:
> >    - ovl_check_encode_origin(dentry) returns 0 as euc_lower (I believe
> > it should return 1 in this case)
> >    - "enc_lower ? ovl_dentry_lower(dentry) : ovl_dentry_upper(dentry)"
> > evaluates to NULL
> >    - NULL is passed as the second argument to ovl_encode_real_fh(), so
> > it crashes
>
> Thank you for the excellent report.
>
> The attached patch (untested) should fix it.
>
> Thanks,
> Miklos





[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux