hi, Luis Henriques, we noticed in https://lore.kernel.org/all/20240307160225.23841-1-lhenriques@xxxxxxx/ it was mentioned this patch is for "ext4/053 fstest failure", however, in our tests, 053 can pass on parent but fail on this commit. 12dbddcebcb8e fs_parser: add helper to define parameters with string and flag types 2de45c422fe6a ext4: fix the parsing of empty string mount parameters 12dbddcebcb8e3e1 2de45c422fe6ae4f64d35df99cd ---------------- --------------------------- fail:runs %reproduction fail:runs | | | :6 100% 6:6 xfstests.ext4.053.fail not sure if there is a xfstests patch works with this patch? Thanks! below report just FYI. Hello, kernel test robot noticed "xfstests.ext4.053.fail" on: commit: 2de45c422fe6ae4f64d35df99cdaf2c6fee2a5ac ("[PATCH v2 2/3] ext4: fix the parsing of empty string mount parameters") url: https://github.com/intel-lab-lkp/linux/commits/Luis-Henriques/fs_parser-add-helper-to-define-parameters-with-string-and-flag-types/20240308-104759 base: https://git.kernel.org/cgit/linux/kernel/git/tytso/ext4.git dev patch link: https://lore.kernel.org/all/20240307160225.23841-3-lhenriques@xxxxxxx/ patch subject: [PATCH v2 2/3] ext4: fix the parsing of empty string mount parameters in testcase: xfstests version: xfstests-x86_64-9b6df9a0-1_20240318 with following parameters: disk: 4HDD fs: ext4 test: ext4-053 compiler: gcc-12 test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (Skylake) with 32G memory (please refer to attached dmesg/kmsg for entire log/backtrace) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <oliver.sang@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-lkp/202403251019.50cab6c8-oliver.sang@xxxxxxxxx 2024-03-22 09:38:10 export TEST_DIR=/fs/sdb1 2024-03-22 09:38:10 export TEST_DEV=/dev/sdb1 2024-03-22 09:38:10 export FSTYP=ext4 2024-03-22 09:38:10 export SCRATCH_MNT=/fs/scratch 2024-03-22 09:38:10 mkdir /fs/scratch -p 2024-03-22 09:38:10 export SCRATCH_DEV=/dev/sdb4 2024-03-22 09:38:10 echo ext4/053 2024-03-22 09:38:10 ./check -E tests/exclude/ext4 ext4/053 FSTYP -- ext4 PLATFORM -- Linux/x86_64 lkp-skl-d05 6.8.0-rc3-00019-g2de45c422fe6 #1 SMP PREEMPT_DYNAMIC Sat Mar 16 03:20:13 CST 2024 MKFS_OPTIONS -- -F /dev/sdb4 MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb4 /fs/scratch ext4/053 [failed, exit status 1]- output mismatch (see /lkp/benchmarks/xfstests/results//ext4/053.out.bad) --- tests/ext4/053.out 2024-03-18 16:30:59.000000000 +0000 +++ /lkp/benchmarks/xfstests/results//ext4/053.out.bad 2024-03-22 09:44:06.379217460 +0000 @@ -1,2 +1,3 @@ QA output created by 053 Silence is golden. +SHOULD FAIL mounting ext4 "test_dummy_encryption=" (mount unexpectedly succeeded) FAILED ... (Run 'diff -u /lkp/benchmarks/xfstests/tests/ext4/053.out /lkp/benchmarks/xfstests/results//ext4/053.out.bad' to see the entire diff) Ran: ext4/053 Failures: ext4/053 Failed 1 of 1 tests The kernel config and materials to reproduce are available at: https://download.01.org/0day-ci/archive/20240325/202403251019.50cab6c8-oliver.sang@xxxxxxxxx -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
