Re: [syzbot] [overlayfs?] WARNING in ovl_copy_up_file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Mar 13, 2024 at 12:23 PM syzbot
<syzbot+3abd99031b42acf367ef@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> Hello,
> syzbot found the following issue on:
> HEAD commit:    707081b61156 Merge branch 'for-next/core', remote-tracking..
> git tree:       git:// for-kernelci
> console output:
> kernel config:
> dashboard link:
> compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> userspace arch: arm64
> syz repro:
> C reproducer:
> Downloadable assets:
> disk image:
> vmlinux:
> kernel image:
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+3abd99031b42acf367ef@xxxxxxxxxxxxxxxxxxxxxxxxx
> evm: overlay not supported
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 6187 at fs/overlayfs/copy_up.c:239 ovl_copy_up_file+0x624/0x674 fs/overlayfs/copy_up.c:330


The WARN_ON that I put in ovl_verify_area() may be too harsh.
I think they can happen if lower file is changed (i_size) while file is being
copied up after reading i_size into the copy length and this could be
the case with this syzbot reproducer that keeps mounting overlayfs
instances over same path.

Should probably demote those WARN_ON to just returning EIO?


[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux