On Mon, 22 Jan 2024 at 20:51, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > +void ovl_layer_set_xwhiteouts(struct ovl_fs *ofs, > + const struct ovl_layer *layer) > +{ > + if (layer->has_xwhiteouts) > + return; > + > + /* Write once to read-mostly layer properties */ > + ((struct ovl_layer *)layer)->has_xwhiteouts = true; The cast is wrong. After this change *ofs->layers is no longer const, so it should not be marked as such. Looks good otherwise. Thanks, Miklos