Re: [PATCH v4] ovl: mark xwhiteouts directory with overlay.opaque='x'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, 22 Jan 2024 at 20:51, Amir Goldstein <amir73il@xxxxxxxxx> wrote:

> +void ovl_layer_set_xwhiteouts(struct ovl_fs *ofs,
> +                             const struct ovl_layer *layer)
> +{
> +       if (layer->has_xwhiteouts)
> +               return;
> +
> +       /* Write once to read-mostly layer properties */
> +       ((struct ovl_layer *)layer)->has_xwhiteouts = true;

The cast is wrong.  After this change *ofs->layers is no longer const,
so it should not be marked as such.

Looks good otherwise.


[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux