On Fri, Dec 15, 2023 at 12:17 PM Wang Jinchao <wangjinchao@xxxxxxxxxxx> wrote: > > remove the second including of linux/posix_acl.h > > Signed-off-by: Wang Jinchao <wangjinchao@xxxxxxxxxxx> > --- > fs/overlayfs/inode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c > index c63b31a460be..2003425875d9 100644 > --- a/fs/overlayfs/inode.c > +++ b/fs/overlayfs/inode.c > @@ -14,7 +14,6 @@ > #include <linux/fileattr.h> > #include <linux/security.h> > #include <linux/namei.h> > -#include <linux/posix_acl.h> > #include <linux/posix_acl_xattr.h> > #include "overlayfs.h" > Since both posix_acl.h and posix_acl_xattr.h are included by overlayfs.h I would rather remove them both including the first posix_acl.h include. It is far from being the only duplicate include in "overlayfs.h" and it is not important enough IMO to start a cleanup project, but if you are going to tidy up includes for a particular file, I'd rather use the opportunity to cleanup that duplicity as well. Thanks, Amir.
