On Tue, Nov 14, 2023 at 05:32:39PM +0200, Amir Goldstein wrote: > Hi Christian, > > I realize you won't have time to review this week, but wanted to get > this series out for review for a wider audience soon. > > During my work on fanotify "pre content" events [1], Jan and I noticed > some inconsistencies in the call sites of security_file_permission() > hooks inside rw_verify_area() and remap_verify_area(). > > The majority of call sites are before file_start_write(), which is how > we want them to be for fanotify "pre content" events. > > For splice code, there are many duplicate calls to rw_verify_area() > for the entire range as well as for partial ranges inside iterator. > > This cleanup series, mostly following Jan's suggestions, moves all > the security_file_permission() hooks before file_start_write() and > eliminates duplicate permission hook calls in the same call chain. > > The last 3 patches are helpers that I used in fanotify patches to > assert that permission hooks are called with expected locking scope. > > My hope is to get this work reviewed and staged in the vfs tree > for the 6.8 cycle, so that I can send Jan fanotify patches for > "pre content" events based on a stable branch in the vfs tree. > > Thanks, > Amir. You can add Reviewed-by: Josef Bacik <josef@xxxxxxxxxxxxxx> to patches 1-11. Thanks, Josef
