On Thu, Oct 12, 2023 at 11:33 AM Christian Brauner <brauner@xxxxxxxxxx> wrote:
>
> On Wed, Oct 11, 2023 at 07:46:13PM +0300, Amir Goldstein wrote:
> > Before commit b36a5780cb44 ("ovl: modify layer parameter parsing"),
> > spaces and commas in lowerdir mount option value used to be escaped using
> > seq_show_option().
> >
> > In current upstream, when lowerdir value has a space, it is not escaped
> > in /proc/mounts, e.g.:
> >
> > none /mnt overlay rw,relatime,lowerdir=l l,upperdir=u,workdir=w 0 0
> >
> > which results in broken output of the mount utility:
> >
> > none on /mnt type overlay (rw,relatime,lowerdir=l)
> >
> > Store the original lowerdir mount options before unescaping and show
> > them using the same escaping used for seq_show_option() in addition to
> > escaping the colon separator character.
> >
> > Fixes: b36a5780cb44 ("ovl: modify layer parameter parsing")
> > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
> > ---
>
> Seems good to me.
FYI, test pushed to
https://github.com/amir73il/xfstests/commits/overlayfs-devel
Thanks,
Amir.
