Re: [regression?] escaping commas in overlayfs mount options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 11, 2023 at 03:06:49PM +0300, Amir Goldstein wrote:
> On Wed, Oct 11, 2023 at 1:18 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> >
> > On Wed, 11 Oct 2023 at 10:45, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> >
> > >
> > > We could add new keys:
> > > lowerdir_first=,lowerdir_next=,lowerdatadir_next=
> > > as explicit variants for the "[^:]",":","::" prefix detection
> > > and those don't need to be unescaped.
> >
> > Good idea.  I'd merge "lowerdir_first" and "lowerdir_next" into
> > "lowerdir_one" or whatever for simplicity.  I'd also consider dropping
> > the prefix detection, since it has only been in mainline for one
> > cycle.
> >
> 
> OK.
> 
> Christian,
> 
> Do you know any userspace that already uses your new append prefixes?

I'm not sure if @Karel already ported libmount to rely on this.
The new layer parsing where you can append and replace layers was done
so that we can have the maximum number of allowed lower layers.

So in the future I would expect libmount should parse the lowerdir,
upperdir, workdir strings and split them up in userspace before passing
them to the kernel.



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux