On Thu, Jul 20, 2023 at 6:37 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > Hi Miklos, > > These prep patches are needed for my start-write-safe series [1]. > This is not urgent and the prep patches don't need to be merged > for next cycle, but I think these are good changes regardless, > so wanted to post them for early review - if you like them you can > queue them for 6.6. > > It is quite hard to do the review of the locking reorder patch from the > diff itself and I couldn't figure out a better way to split this change. > I've intentionally left some otherwise useless out: goto labels to > make the patch review a bit simper - they could be removed later. > > On the good side, lockdep was very tough with me and it easily detected > bugs in the earlier versions of the patches. > > Going on vacation. will be back round rc6. Hi Miklos, Have you had a chance to look at these changes? I can queue them up in overlayfs-next if they are acceptable. Thanks, Amir. > > [1] https://github.com/amir73il/linux/commits/start-write-safe > > Amir Goldstein (2): > ovl: reorder ovl_want_write() after ovl_inode_lock() > ovl: avoid lockdep warning with open and llseek of lower file > > fs/overlayfs/copy_up.c | 34 +++++++++++++------- > fs/overlayfs/dir.c | 71 ++++++++++++++++++------------------------ > fs/overlayfs/export.c | 7 +---- > fs/overlayfs/inode.c | 56 ++++++++++++++++----------------- > fs/overlayfs/util.c | 18 +++++++++-- > 5 files changed, 97 insertions(+), 89 deletions(-) > > -- > 2.34.1 >
