On Thu, Jul 6, 2023 at 9:10 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > On Mon, Jul 3, 2023 at 11:11 AM Alexander Larsson <alexl@xxxxxxxxxx> wrote: > > > > Cool, I wanted to look at this, but was on PTO last week. > > It looks good to me, and I synced this to: > > https://github.com/alexlarsson/xfstests/commits/verity-tests > > To avoid drift. > > > > I pushed the overlay-verity series to overlayfs-next, so you may > expect "finishing touches" bug reports from bots in the near future. > As long as they are minor fixes, you can fix your branch and let me know > and I will update overlayfs-next. > > Miklos may yet have feedback on the final version, but I think all his > comments were addressed including the ACK from Eric (thanks!). Nice! > Eric, > > There was no posting of v5 that addressed your v4 review comments, > so we do not have your RVB/ACK for patches 2-4. > Let me know if you want me to add that to the patches. > > Alex, > > wrt overlay verity-tests, please submit those tests along with the lowerdata > tests to fstests anytime between now and the 6.6 merge window. > The tests are properly equipped to check for the feature and testers can > use them to test linux-next. I'll have a look at this soon. > For test overlay/080 you may add: > Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> > For test overlay/079 you may retain my authorship or assume authorship > I don't mind as it was co-authored and you took it to the finish line. > > Thanks, > Amir. > -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson Red Hat, Inc alexl@xxxxxxxxxx alexander.larsson@xxxxxxxxx
