On Mon, Jul 3, 2023 at 9:24 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > On Wed, Jun 21, 2023 at 01:18:27PM +0200, Alexander Larsson wrote: > > +static int ovl_ensure_verity_loaded(struct path *datapath) > > +{ > > + struct inode *inode = d_inode(datapath->dentry); > > + const struct fsverity_info *vi; > > + struct file *filp; > > + > > + vi = fsverity_get_info(inode); > > + if (vi == NULL && IS_VERITY(inode)) { > > Can you please use '!fsverity_active(inode)' instead of > 'fsverity_get_info(inode) == NULL'? The result is exactly the same, but > fsverity_active() is the intended "API" for code outside fs/verity/. > fsverity_get_info() is in the header only because fsverity_active() calls it. Changed this in git: https://github.com/alexlarsson/linux/tree/overlay-verity -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson Red Hat, Inc alexl@xxxxxxxxxx alexander.larsson@xxxxxxxxx