On Tue, 20 Jun 2023 at 10:48, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
> On Sat, 17 Jun 2023 at 10:47, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>
> > @@ -1332,10 +1337,17 @@ static int ovl_make_workdir(struct super_block *sb, struct ovl_fs *ofs,
> > if (err) {
> > pr_warn("failed to set xattr on upper\n");
> > ofs->noxattr = true;
> > - if (ofs->config.index || ofs->config.metacopy) {
> > - ofs->config.index = false;
> > + if (ovl_redirect_follow(ofs)) {
> > + ofs->config.redirect_mode = OVL_REDIRECT_NOFOLLOW;
> > + pr_warn("...falling back to redirect_dir=nofollow.\n");
>
>
> So if there's no xattr support, then there won't be any redirects to
> follow. Is this just asserting the fact?
>
> Should this be a separate patch?
Oh, I see you are changing the ovl_redirect_dir() logic. Ack.
Thanks,
Miklos
