On Thu, Jun 15, 2023 at 02:22:26PM +0300, Amir Goldstein wrote: > +/** > + * kernel_file_open - open a file for kernel internal use > + * @path: path of the file to open > + * @flags: open flags > + * @inode: the inode > + * @cred: credentials for open > + * > + * Open a file that is not accounted in nr_files. > + * This is only for kernel internal use, and must not be installed into > + * file tables or such. This reads a litte odd. How about: * Open a file for use by in-kernel consumers. The file is not accounted * against nr_files and must not be installed into the file descriptor table. With that: Reviewed-by: Christoph Hellwig <hch@xxxxxx>