Re: [PATCH v2 1/3] fs: rename FMODE_NOACCOUNT to FMODE_INTERNAL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 12, 2023 at 7:27 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Sun, Jun 11, 2023 at 04:27:30PM +0300, Amir Goldstein wrote:
> > Rename the flag FMODE_NOACCOUNT that is used to mark internal files of
> > overlayfs and cachefiles to the more generic name FMODE_INTERNAL, which
> > also indicates that the file's f_path is possibly "fake".
>
> FMODE_INTERNAL is completely meaningless.  Plase come up with a name
> that actually explain what is special about these files.
>

Well, I am not sure if FMODE_FAKE_PATH in v3 is a better name,
because you did rightfully say that "fake path" is not that descriptive,
but I will think of a better way to describe "fake path" and match the
flag to the file container name.

Thanks,
Amir.




[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux