Re: [PATCH v2 2/3] fs: introduce f_real_path() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 11, 2023 at 04:27:31PM +0300, Amir Goldstein wrote:
> Overlayfs knows the real path of underlying dentries.  Add an optional
> struct vfsmount out argument to ->d_real(), so callers could compose the
> real path.
> 
> Add a helper f_real_path() that uses this new interface to return the
> real path of f_inode, for overlayfs internal files whose f_path if a
> "fake" overlayfs path and f_inode is the underlying real inode.

I really don't like this ->d_real nagic.  Most callers of it
really can't ever be on overlayfs.  So I'd suggest we do an audit
of the callers of file_dentry and drop all the pointless ones
first, and improve the documentation on when to use it.



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux