On Fri, Jun 9, 2023 at 4:16 PM Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> wrote: > > On 2023/06/09 16:32, Amir Goldstein wrote: > > The audit and tomoyo use of file_fake_path() is not tested > > (CC maintainers), but they both look like user displayed paths, > > so I assumed they's want to preserve the existing behavior > > (i.e. displaying the fake overlayfs path). > > Since I'm not using overlayfs, I don't know the difference between > real path and fake path. Would you explain using command line example? > > mkdir what_path1 > mkdir what_path2 > mkdir what_path3 > mount -t overlayfs ...what_paths_come_here?... For example: mount -t overlayfs overlay /mnt/ovl \ -o lowerdir=what_path1:what_path2:what_path3 > > what the pathname returned by wrapping with file_fake_path() is, and > what the pathname returned by not wrapping with file_fake_path() is? > It depends. if you have an audit rule on /mnt/ovl the path is always the /mnt/ovl/... path (fake_path as well). If you have an audit rule on what_path1 the fake path is /mnt/ovl/... and the real path is /... (the relative path from what_path1). In both cases, the filename itself will be correct. If the rule prints something like %pD2 then it does not really matter which path you use. Thanks, Amir.