On Mon, May 30, 2022 at 08:54:23AM +0300, Amir Goldstein wrote:
> On Sun, May 29, 2022 at 8:59 PM Zorro Lang <zlang@xxxxxxxxxx> wrote:
> >
> > The _require_scratch_shutdown can't help this test case, except use
> > _scratch_shutdown or _scratch_shutdown_handle with it. But this test
> > case does 'shutdown' on $SCRATCH_MNT/file directly. It's not suitable
> > for overlay.
> >
>
> This is not about testing overlayfs.
> It is about testing FS under overlayfs which can detect bugs in FS
> that are otherwise hard to trigger.
> mmap is an especially odd case of overlayfs so I rather not loose this
> test coverage. Please do not apply this patch I will send a fix to the test.
Thanks, if you think it's worth keeping for overlay, I'll drop this patch.
If we change the code as:
if [ $FSTYP = "overlay" ];then
file=$OVL_BASE_SCRATCH_MNT/file
fi
It's actually not testing overlay at all. We might need all testing operations
run on overlay, then shutdown the $OVL_BASE_SCRATCH_MNT. But it looks not simple
to separate the 'shutdown' from the:
$XFS_IO_PROG -x -c "mmap 0 4k" -c "mwrite 0 4k" -c shutdown -c fsync \
-c "mwrite 0 4k" $file | _filter_xfs_io
So what's your plan?
Thanks,
Zorro
>
> Thanks,
> Amir.
>
> > Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx>
> > ---
> > tests/generic/623 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/generic/623 b/tests/generic/623
> > index ea016d91..1083e796 100755
> > --- a/tests/generic/623
> > +++ b/tests/generic/623
> > @@ -11,7 +11,7 @@ _begin_fstest auto quick shutdown
> >
> > . ./common/filter
> >
> > -_supported_fs generic
> > +_supported_fs ^overlay
> > _fixed_by_kernel_commit e4826691cc7e \
> > "xfs: restore shutdown check in mapped write fault path"
> >
> > --
> > 2.31.1
> >
>
