Replace task io account helpers with wrappers that may also collect
per-sb io stats.
Filesystems that want these per-sb io stats collected need to opt-in
with sb_iostats_init().
Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
---
fs/read_write.c | 88 +++++++++++++++++++++++++++++++++++--------------
1 file changed, 64 insertions(+), 24 deletions(-)
diff --git a/fs/read_write.c b/fs/read_write.c
index 0074afa7ecb3..8c599bf2dd78 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -20,6 +20,7 @@
#include <linux/compat.h>
#include <linux/mount.h>
#include <linux/fs.h>
+#include <linux/fs_iostats.h>
#include "internal.h"
#include <linux/uaccess.h>
@@ -34,6 +35,45 @@ const struct file_operations generic_ro_fops = {
EXPORT_SYMBOL(generic_ro_fops);
+static inline void file_iostats_counter_inc(struct file *file, int id)
+{
+ if (file)
+ sb_iostats_counter_inc(file->f_path.mnt->mnt_sb, id);
+}
+
+static inline void file_iostats_counter_add(struct file *file, int id,
+ ssize_t amt)
+{
+ if (file)
+ sb_iostats_counter_add(file->f_path.mnt->mnt_sb, id, amt);
+}
+
+static void file_add_rchar(struct file *file, struct task_struct *tsk,
+ ssize_t amt)
+{
+ file_iostats_counter_add(file, SB_IOSTATS_CHARS_RD, amt);
+ add_rchar(tsk, amt);
+}
+
+static void file_add_wchar(struct file *file, struct task_struct *tsk,
+ ssize_t amt)
+{
+ file_iostats_counter_add(file, SB_IOSTATS_CHARS_WR, amt);
+ add_wchar(tsk, amt);
+}
+
+static void file_inc_syscr(struct file *file, struct task_struct *tsk)
+{
+ file_iostats_counter_inc(file, SB_IOSTATS_SYSCALLS_RD);
+ inc_syscr(current);
+}
+
+static void file_inc_syscw(struct file *file, struct task_struct *tsk)
+{
+ file_iostats_counter_inc(file, SB_IOSTATS_SYSCALLS_WR);
+ inc_syscw(current);
+}
+
static inline bool unsigned_offsets(struct file *file)
{
return file->f_mode & FMODE_UNSIGNED_OFFSET;
@@ -441,9 +481,9 @@ ssize_t __kernel_read(struct file *file, void *buf, size_t count, loff_t *pos)
if (pos)
*pos = kiocb.ki_pos;
fsnotify_access(file);
- add_rchar(current, ret);
+ file_add_rchar(file, current, ret);
}
- inc_syscr(current);
+ file_inc_syscr(file, current);
return ret;
}
@@ -483,9 +523,9 @@ ssize_t vfs_read(struct file *file, char __user *buf, size_t count, loff_t *pos)
ret = -EINVAL;
if (ret > 0) {
fsnotify_access(file);
- add_rchar(current, ret);
+ file_add_rchar(file, current, ret);
}
- inc_syscr(current);
+ file_inc_syscr(file, current);
return ret;
}
@@ -537,9 +577,9 @@ ssize_t __kernel_write(struct file *file, const void *buf, size_t count, loff_t
if (pos)
*pos = kiocb.ki_pos;
fsnotify_modify(file);
- add_wchar(current, ret);
+ file_add_wchar(file, current, ret);
}
- inc_syscw(current);
+ file_inc_syscw(file, current);
return ret;
}
/*
@@ -592,9 +632,9 @@ ssize_t vfs_write(struct file *file, const char __user *buf, size_t count, loff_
ret = -EINVAL;
if (ret > 0) {
fsnotify_modify(file);
- add_wchar(current, ret);
+ file_add_wchar(file, current, ret);
}
- inc_syscw(current);
+ file_inc_syscw(file, current);
file_end_write(file);
return ret;
}
@@ -947,8 +987,8 @@ static ssize_t do_readv(unsigned long fd, const struct iovec __user *vec,
}
if (ret > 0)
- add_rchar(current, ret);
- inc_syscr(current);
+ file_add_rchar(f.file, current, ret);
+ file_inc_syscr(f.file, current);
return ret;
}
@@ -971,8 +1011,8 @@ static ssize_t do_writev(unsigned long fd, const struct iovec __user *vec,
}
if (ret > 0)
- add_wchar(current, ret);
- inc_syscw(current);
+ file_add_wchar(f.file, current, ret);
+ file_inc_syscw(f.file, current);
return ret;
}
@@ -1000,8 +1040,8 @@ static ssize_t do_preadv(unsigned long fd, const struct iovec __user *vec,
}
if (ret > 0)
- add_rchar(current, ret);
- inc_syscr(current);
+ file_add_rchar(f.file, current, ret);
+ file_inc_syscr(f.file, current);
return ret;
}
@@ -1023,8 +1063,8 @@ static ssize_t do_pwritev(unsigned long fd, const struct iovec __user *vec,
}
if (ret > 0)
- add_wchar(current, ret);
- inc_syscw(current);
+ file_add_wchar(f.file, current, ret);
+ file_inc_syscw(f.file, current);
return ret;
}
@@ -1250,8 +1290,8 @@ static ssize_t do_sendfile(int out_fd, int in_fd, loff_t *ppos,
}
if (retval > 0) {
- add_rchar(current, retval);
- add_wchar(current, retval);
+ file_add_rchar(in.file, current, retval);
+ file_add_wchar(out.file, current, retval);
fsnotify_access(in.file);
fsnotify_modify(out.file);
out.file->f_pos = out_pos;
@@ -1261,8 +1301,8 @@ static ssize_t do_sendfile(int out_fd, int in_fd, loff_t *ppos,
in.file->f_pos = pos;
}
- inc_syscr(current);
- inc_syscw(current);
+ file_inc_syscr(in.file, current);
+ file_inc_syscw(out.file, current);
if (pos > max)
retval = -EOVERFLOW;
@@ -1511,13 +1551,13 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in,
done:
if (ret > 0) {
fsnotify_access(file_in);
- add_rchar(current, ret);
+ file_add_rchar(file_in, current, ret);
fsnotify_modify(file_out);
- add_wchar(current, ret);
+ file_add_wchar(file_out, current, ret);
}
- inc_syscr(current);
- inc_syscw(current);
+ file_inc_syscr(file_in, current);
+ file_inc_syscw(file_out, current);
file_end_write(file_out);
--
2.25.1
