Hi Christoph,
On Wed, 2022-01-12 at 19:46 +0100, Christoph Fritz wrote:
> On Wed, 2022-01-12 at 19:33 +0100, Christoph Fritz wrote:
>> This patch is fixing a NULL pointer dereference to get a recently
>> introduced warning message working.
Good catch!
> With that patch applied, a lot of these are popping up now:
>
> [ 7.132514] overlayfs: failed to retrieve upper fileattr (index/#26, err=-25)
>
> [...]
>
> These have been -ENOIOCTLCMD errors but got (falsely?) converted to
> -ENOTTY by the recently introduced commit 5b0a414d06c3 ("ovl: fix filattr copy-up failure"):
Which filesystem are you using for upper (and lower) in your mount?
Presumably the upper doesn't support file attributes, if it returns
-ENOIOCTLCMD? If so, I guess the question would be what behavior
overlayfs should have when attributes can't be copied from lower to
upper, which is actually a question Miklos raised when that commit was
being worked on![^1] Perhaps your use case can help inform a good
answer.
Cheers,
Kevin
[^1]: https://lore.kernel.org/linux-unionfs/CAJfpegsRo3e-9B64W37YrmvDcjo0QB9t+coAW3mO6TSqdROz2w@xxxxxxxxxxxxxx/
