On Wed, 18 Aug 2021 at 20:34, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Aug 18, 2021 at 6:34 AM Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote:
> >
> > struct posix_acl *get_cached_acl_rcu(struct inode *inode, int type)
> > {
> > - return rcu_dereference(*acl_by_type(inode, type));
> > + struct posix_acl *acl = rcu_dereference(*acl_by_type(inode, type));
> > +
> > + if (acl == ACL_DONT_CACHE)
> > + acl = inode->i_op->get_acl(inode, type, LOOKUP_RCU);
> > +
> > + return acl;
> > }
>
> What? No.
>
> You just made get_cached_acl_rcu() return ERR_PTR(-EINVAL) for most filesystems.
>
> So now you've changed the behavior of get_cached_acl_rcu() ENTIRELY.
>
> It used to return either
> (a) the ACL
> (b) NULL
> (c) ACL_DONT_CACHE/ACL_NOT_CACHED
>
> but now you've changed that (c) case to "ACL_NOT_CACHED or random error value".
>
> You can't just mix these kinds of entirely different return values like that.
>
> So no, this is not at all acceptable.
>
> I would suggest:
>
> (a) make the first patch actually test explicitly for LOOKUP_RCU, so
> that it's clear to the filesystems what is going on.
>
> So instead of that pattern of
>
> if (flags)
> return ERR_PTR(-EINVAL);
>
> I'd suggest using
>
> if (flags & LOOKUP_RCU)
> return ERR_PTR(-ECHILD);
Okay.
>
> so that it actually matches what lookup does for the "I can't do
> this under RCU", and so that any reader of the code understands what
> "flags" is all about.
>
> And then
>
> (b) make the get_cached_acl_rcu() case handle errors _properly_
> instead of mixing the special ACL cache markers with error returns.
>
> So instead of
>
> if (acl == ACL_DONT_CACHE)
> acl = inode->i_op->get_acl(inode, type, LOOKUP_RCU);
>
> maybe something more along the lines of
>
> if (acl == ACL_DONT_CACHE) {
> struct posix_acl *lookup_acl;
> lookup_acl = inode->i_op->get_acl(inode, type, LOOKUP_RCU);
> if (!IS_ERR(lookup_acl))
> acl = lookup_acl;
> }
>
> or whatever.
Yes, that's better. Just to explain why my version was not actually
buggy: ACL_DONT_CACHE is only used in overlayfs and not in any other
filesystem, so ->get_acl(... LOOKUP_RCU) not returning an error was
implicit in the implementation. But your version makes that error
handling explicit, which is definitely an improvement.
>
> I disagree with Al that a "bool" would be better. I think LOOKUP_RCU
> is good documentation, and consistent with lookup, but it really needs
> to be *consistent*. Thus that
>
> if (flags & LOOKUP_RCU)
> return ERR_PTR(-ECHILD);
>
> pattern, not some "test underscibed flags, return -EINVAL" pattern
> that looks entirely nonsensical.
Al suggested:
if (rcu)
return ERR_PTR(-ECHILD);
which is also good documentation. It also makes sure that "flags" is
not overloaded with other functionality (which was the reason for the
defensive "if any flag set return error" pattern).
Thanks,
Miklos
