On Thu, May 27, 2021 at 5:06 PM Vyacheslav Yurkov <uvv.mail@xxxxxxxxx> wrote: > > From: Vyacheslav Yurkov <Vyacheslav.Yurkov@xxxxxxxxxx> > > Currently decoding origin with lower null uuid is not allowed when user > opted-in to one of the new features that require following the lower inode Confusing. It is not allowed *unless* user opted-in... I admit the comment could have been more clear. The commit subject is also not accurate, maybe: "ovl: disable decoding null uuid with redirect dir" Thanks, Amir. > of non-dir upper (index, xino, metacopy). Now we add redirect_dir too to > that feature list. > > Signed-off-by: Vyacheslav Yurkov <Vyacheslav.Yurkov@xxxxxxxxxx> > --- > fs/overlayfs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c > index b01d4147520d..97ea35fdd933 100644 > --- a/fs/overlayfs/super.c > +++ b/fs/overlayfs/super.c > @@ -1600,7 +1600,7 @@ static bool ovl_lower_uuid_ok(struct ovl_fs *ofs, const uuid_t *uuid) > * lower inode of non-dir upper. > */ > if (!ofs->config.index && !ofs->config.metacopy && > - ofs->config.xino != OVL_XINO_ON && > + !ofs->config.redirect_dir && ofs->config.xino != OVL_XINO_ON && > uuid_is_null(uuid)) > return false; > > -- > 2.25.1 >
