On Tue, Feb 9, 2021 at 3:02 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > Now overlayfs allow unpriviliged mounts. That is root inside a non-init > user namespace can mount overlayfs. This was added in 5.10 kernel. > > Giuseppe tried to mount overlayfs with option "context" and it failed > with error -EACCESS. > > $ su test > $ unshare -rm > $ mkdir -p lower upper work merged > $ mount -t overlay -o lowerdir=lower,workdir=work,upperdir=upper,userxattr,context='system_u:object_r:container_file_t:s0' none merged > > This fails with -EACCESS. It works if option "-o context" is not specified. > > Little debugging showed that selinux_set_mnt_opts() returns -EACCESS. > > So this patch adds "overlay" to the list, where it is fine to specific > context from non init_user_ns. > > Reported-by: Giuseppe Scrivano <gscrivan@xxxxxxxxxx> > Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx> > --- > security/selinux/hooks.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This seems reasonable, but since we are at -rc7 this week it will need to wait until after the upcoming merge window. It's too late in the cycle for new features. -- paul moore www.paul-moore.com
