On Sun, Jan 24, 2021 at 05:32:15PM +0200, Amir Goldstein wrote:
> On Sun, Jan 24, 2021 at 5:14 PM Eryu Guan <guan@xxxxxxx> wrote:
> >
[snap]
> > >
> > > if (create) {
> > > ret = create_test_area(argv[argc-1]);
> > > - if (ret || !runtest) {
> > > + if (ret || allow_existing) {
> >
> > With this change, compiler warns about 'runtest' is set but not used,
> > and 'allow_existing' now indicates '!runtest' implicitly, which seems
> > subtle. I think it's better to keep 'runtest' as the indicator to
> > actually run the test?
> >
>
> Sure, I removed it by mistake.
Then this is the only place that needs update. I can fix it on commit,
no need to resend then.
Thanks,
Eryu
