On Sat, Dec 19, 2020 at 07:53:12AM -0500, Jeff Layton wrote: > On Sat, 2020-12-19 at 06:13 +0000, Matthew Wilcox wrote: > > On Thu, Dec 17, 2020 at 10:00:37AM -0500, Jeff Layton wrote: > > > Overlayfs's volatile mounts want to be able to sample an error for their > > > own purposes, without preventing a later opener from potentially seeing > > > the error. > > > > umm ... can't they just copy the errseq_t they're interested in, followed > > by calling errseq_check() later? > > > > They don't want the sampling for the volatile mount to prevent later > openers from seeing an error that hasn't yet been reported. That's why they should use errseq_check(), not errseq_check_and_advance() ...