On Fri 04-12-20 22:49:13, Chengguang Xu wrote: > ---- 在 星期五, 2020-11-13 14:55:46 Chengguang Xu <cgxu519@xxxxxxxxxxxx> 撰写 ---- > > Current syncfs(2) syscall on overlayfs just calls sync_filesystem() > > on upper_sb to synchronize whole dirty inodes in upper filesystem > > regardless of the overlay ownership of the inode. In the use case of > > container, when multiple containers using the same underlying upper > > filesystem, it has some shortcomings as below. > > > > (1) Performance > > Synchronization is probably heavy because it actually syncs unnecessary > > inodes for target overlayfs. > > > > (2) Interference > > Unplanned synchronization will probably impact IO performance of > > unrelated container processes on the other overlayfs. > > > > This series try to implement containerized syncfs for overlayfs so that > > only sync target dirty upper inodes which are belong to specific overlayfs > > instance. By doing this, it is able to reduce cost of synchronization and > > will not seriously impact IO performance of unrelated processes. > > Hi Miklos, > > I think this version has addressed all previous issues and comments from Jack > and Amir. Have you got time to review this patch series? Yes, the patches now look good to me. Feel free to add: Acked-by: Jan Kara <jack@xxxxxxx> Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
