Re: [PATCH v2] ovl: check for incomapt features in work dir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 30, 2020 at 11:28:03PM +0300, Amir Goldstein wrote:

[..]
> @@ -1079,21 +1090,29 @@ static void ovl_workdir_cleanup_recurse(struct path *path, int level)
>  				continue;
>  			if (p->len == 2 && p->name[1] == '.')
>  				continue;
> +		} else if (incompat) {
> +			pr_warn("overlay with incompat feature '%.*s' cannot be mounted\n",
> +				p->len, p->name);
> +			err = -EEXIST;
> +			break;

Hi Amir,

Should above be pr_err() instead of pr_warn()?

Apart from above minor nit, this patch looks good to me. I did a quick
test and it works.

Vivek




[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux