Hi Amir, On Sun, May 31, 2020 at 02:01:53PM +0300, Amir Goldstein wrote: > Eryu, > > unionmount testsuite has a lot more test coverage than the overlay > xfstests, but it has a lot less exposure to testers. > > The various test setups that I have added to unionmount testsuite since > I took over the maintanace of the testsuite have even smaller exposure > to testers. > > These patches add overlay tests that are used as a harness to run > different setups of unionmount testsuite. I have been using this method > for over two year for testing my overlayfs branches. > > What does it take to install unionmount testsuite? > As README.overlay says: > > git clone https://github.com/amir73il/unionmount-testsuite.git > ln -s $PWD/unionmount-testsuite <path-to-xfstests>/src/ I'm really sorry for the long-long delay.. The test itself looks really good to me, my only concern is that the updates in unionmount repo are not visible to fstests, and may cause new failures, which are out of fstests' control. But I'm not sure if this really is a problem for people. I came up with two options anyway - add unionmount tests as a submodule of fstests - put unionmount tests in fstests I'd like to hear what people think about this patchset, any other comments & suggestions are welcomed! Thanks, Eryu > > Thanks, > Amir. > > Amir Goldstein (3): > overlay: run unionmount testsuite test cases > overlay: add unionmount tests with multi lower layers > overlay: add unionmount tests with nested overlay > > README.overlay | 15 ++++++++++++ > common/config | 2 ++ > common/overlay | 54 +++++++++++++++++++++++++++++++++++++++++++ > tests/overlay/100 | 38 ++++++++++++++++++++++++++++++ > tests/overlay/100.out | 2 ++ > tests/overlay/101 | 39 +++++++++++++++++++++++++++++++ > tests/overlay/101.out | 2 ++ > tests/overlay/102 | 40 ++++++++++++++++++++++++++++++++ > tests/overlay/102.out | 2 ++ > tests/overlay/103 | 38 ++++++++++++++++++++++++++++++ > tests/overlay/103.out | 2 ++ > tests/overlay/104 | 39 +++++++++++++++++++++++++++++++ > tests/overlay/104.out | 2 ++ > tests/overlay/105 | 40 ++++++++++++++++++++++++++++++++ > tests/overlay/105.out | 2 ++ > tests/overlay/106 | 41 ++++++++++++++++++++++++++++++++ > tests/overlay/106.out | 2 ++ > tests/overlay/107 | 41 ++++++++++++++++++++++++++++++++ > tests/overlay/107.out | 2 ++ > tests/overlay/108 | 41 ++++++++++++++++++++++++++++++++ > tests/overlay/108.out | 2 ++ > tests/overlay/109 | 41 ++++++++++++++++++++++++++++++++ > tests/overlay/109.out | 2 ++ > tests/overlay/110 | 39 +++++++++++++++++++++++++++++++ > tests/overlay/110.out | 2 ++ > tests/overlay/111 | 40 ++++++++++++++++++++++++++++++++ > tests/overlay/111.out | 2 ++ > tests/overlay/112 | 40 ++++++++++++++++++++++++++++++++ > tests/overlay/112.out | 2 ++ > tests/overlay/113 | 41 ++++++++++++++++++++++++++++++++ > tests/overlay/113.out | 2 ++ > tests/overlay/114 | 39 +++++++++++++++++++++++++++++++ > tests/overlay/114.out | 2 ++ > tests/overlay/115 | 40 ++++++++++++++++++++++++++++++++ > tests/overlay/115.out | 2 ++ > tests/overlay/116 | 40 ++++++++++++++++++++++++++++++++ > tests/overlay/116.out | 2 ++ > tests/overlay/117 | 41 ++++++++++++++++++++++++++++++++ > tests/overlay/117.out | 2 ++ > tests/overlay/group | 18 +++++++++++++++ > 40 files changed, 843 insertions(+) > create mode 100755 tests/overlay/100 > create mode 100644 tests/overlay/100.out > create mode 100755 tests/overlay/101 > create mode 100644 tests/overlay/101.out > create mode 100755 tests/overlay/102 > create mode 100644 tests/overlay/102.out > create mode 100755 tests/overlay/103 > create mode 100644 tests/overlay/103.out > create mode 100755 tests/overlay/104 > create mode 100644 tests/overlay/104.out > create mode 100755 tests/overlay/105 > create mode 100644 tests/overlay/105.out > create mode 100755 tests/overlay/106 > create mode 100644 tests/overlay/106.out > create mode 100755 tests/overlay/107 > create mode 100644 tests/overlay/107.out > create mode 100755 tests/overlay/108 > create mode 100644 tests/overlay/108.out > create mode 100755 tests/overlay/109 > create mode 100644 tests/overlay/109.out > create mode 100755 tests/overlay/110 > create mode 100644 tests/overlay/110.out > create mode 100755 tests/overlay/111 > create mode 100644 tests/overlay/111.out > create mode 100755 tests/overlay/112 > create mode 100644 tests/overlay/112.out > create mode 100755 tests/overlay/113 > create mode 100644 tests/overlay/113.out > create mode 100755 tests/overlay/114 > create mode 100644 tests/overlay/114.out > create mode 100755 tests/overlay/115 > create mode 100644 tests/overlay/115.out > create mode 100755 tests/overlay/116 > create mode 100644 tests/overlay/116.out > create mode 100755 tests/overlay/117 > create mode 100644 tests/overlay/117.out > > -- > 2.17.1 >
