On Tue, Jul 14, 2020 at 9:38 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > On Tue, Jul 14, 2020 at 09:32:51PM +0300, Amir Goldstein wrote: > > On Tue, Jul 14, 2020 at 9:18 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > > > > > On Mon, Jul 13, 2020 at 05:19:43PM +0300, Amir Goldstein wrote: > > > > With index feature enabled, on failure to create index dir, overlay > > > > is being mounted read-only. However, we do not forbid user to remount > > > > overlay read-write. Fix that by setting ofs->workdir to NULL, which > > > > prevents remount read-write. > > > > > > > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > > > > > This patch does not apply for me. What branch you have generated it > > > against. I am using 5.8-rc4. > > > > It's from my ovl-fixes branch. > > > > Sorry I did not notice that it depends on a previous patch that Miklos > > just picked up: > > > > "ovl: fix oops in ovl_indexdir_cleanup() with nfs_export=on" > > I dont see it here. > > https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git/log/?h=overlayfs-next > > Is there another tree/branch miklos is maintaining which I should use? Or > you just happen to know that Miklos has committed this internally and > not published yet. > Sorry. He just replied to the email "applied" a few hours ago. If you need the patch it's on my ovl-fixes branch in github. Thanks, Amir.