On Tue, Jul 14, 2020 at 6:09 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > On Tue, Jul 14, 2020 at 4:58 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > > On Tue, Jul 14, 2020 at 5:52 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > > > > > On Mon, Jul 13, 2020 at 4:19 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > > > > > > Without upperdir mount option, there is no index dir and the dependency > > > > checks nfs_export => index for mount options parsing are incorrect. > > > > > > > > Allow the combination nfs_export=on,index=off with no upperdir and move > > > > the check for dependency redirect_dir=nofollow for non-upper mount case > > > > to mount options parsing. > > > > > > Okay, but does this combination make any sense? > > > > Do you mean configuration of non-upper exported to NFS? > > Why not? Anyway, we allowed it and regressed it. > > Ah, right. I was confused and thought we'd want to allow > nfs_eport=on,index=on with no upper dir. But that's nonsense > obviously. > Heh no. FYI, I got to this because working on the configuration: ro,upperdir=...,nfs_eport=on,index=off for snapshot, since it's a (forced) read-only mount, even though it has an upperdir and copy ups, it has no upper rename/unlink, so there is no need for an index to follow from lower to upper nor to follow redirect from upper to lower. Thanks, Amir.
