On Mon, Jun 01, 2020 at 06:15:44PM +0300, Amir Goldstein wrote: [..] > > > But see one improvement below. > > > Also, please make sure to run unionmount setups: > > > > > > ./run --ov=10 --verify > > > ./run --ov=10 --meta --verify > > > > > > --verify will enable index and check st_dev;st_ino are not broken > > > on copy up. --ov=10 will cause lower hardlink copy up, because > > > after hardlink is creates by some test, upper is rotated to mid layer > > > and next modifying operation will trigger the hardlink copy up. > > > > Hi Amir, > > > > I ran above configurations and it passes with the patches. > > > > Thanks for these suggestions. I used to run only "./run --ov" so far. > > It will be nice to have some documentation about --meta, --verify in README. > > > > Yeh, I never get to it. > But now I finally posted xfstest integration, so we can just add more > xfstests to run metacopy configurations on a full test cycle. Yes, I saw those patches. Very nice. Will be good to run all overlay tests from single place. Once your patches get merged, I definitely want to add some more tests to run "--meta" tests. Vivek
