Re: [PATCH] overlay: return required buffer size for file handles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 5, 2020 at 5:58 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>
> On Mon, May 4, 2020 at 10:50 PM Lubos Dolezel <lubos@xxxxxxxxxxxx> wrote:
> >
> > Hello,
> >
> > overlayfs doesn't work well with the fanotify mechanism.
> >
> > Fanotify first probes for the required buffer size for the file handle,
> > but overlayfs currently bails out without passing the size back.
> >
> > That results in errors in the kernel log, such as:
> >
> > [527944.485384] overlayfs: failed to encode file handle (/, err=-75, buflen=0, len=29, type=1)
> > [527944.485386] fanotify: failed to encode fid (fsid=ae521e68.a434d95f, type=255, bytes=0, err=-2)
> >
> > Lubos
>
> Hi Lubos,
>
> Thank you for the fix.
> Please leave greeting (Hello) and this line outside of the commit message.
> You may add extra notes for email after --- line
>
> >
> > Signed-off-by: Lubos Dolezel <lubos@xxxxxxxxxxxx>
>
> After fixing below you may add for v2:
> Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>
>

Pushed my v2 to:
https://github.com/amir73il/linux/commits/ovl-fixes

Along with Dan's patch.

Tests are at:
https://github.com/amir73il/xfstests/commits/ovl-fixes

Thanks,
Amir.



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux