On Thu, Apr 23, 2020 at 1:17 PM JeffleXu <jefflexu@xxxxxxxxxxxxxxxxx> wrote: > > > On 4/23/20 4:27 PM, Amir Goldstein wrote: > > On Thu, Apr 23, 2020 at 10:06 AM JeffleXu <jefflexu@xxxxxxxxxxxxxxxxx> wrote: > >> It seems that MS_NOSEC flag would be problematic for network filesystems. > >> > >> > >> @Amir, would you please give some suggestions on if this would break the > >> > >> permission control down when 'NFS export' feature enabled ? > >> > > I cannot think of anything specific to NFS export. > > I think you are confusing NFS server with NFS client permissions. > > I think network filesystems do not set SB_NOSEC, because client > > may not have an coherent state of the xattr on server and other clients. > > > > To reflect on overlayfs, I think overlayfs should inherit the SB_NOSEC > > flag from upper fs, which is most likelihood will be set. > > Makes sense. So maybe the following patch would be more appropriate. If > it is OK I will send a v2 patch then. > Yes, it looks better. But I could be missing other aspects. Better post v2 and wait for more comments from Miklos. Thanks, Amir.
