> > If I specify UNIONMOUNT_BASEDIR, then --samefs should be implied? > > > > This might have made sense with the meaning of UNIONMOUNT_BASEDIR > as it is in current posting, but with intended change, I suppose an empty > UNIONMOUNT_LOWERDIR could mean --samefs. > When both --samefs and UNIONMOUNT_LOWERDIR are specified, I'll > throw a warning that UNIONMOUNT_LOWERDIR is ignored. > Vivek, I updated the logic per some of your suggestions and push to: https://github.com/amir73il/unionmount-testsuite/commits/overlayfs-devel The example of how xfstests uses it is at: https://github.com/amir73il/xfstests/commits/unionmount Since I am mostly interested in feedback on config interface, I'll just paste the commit message here (same text is also in README). In short: if you set UNIONMOUNT_BASEDIR to virtiofs path and execute run --ov, all layers will be created under that virtiofs path. Let me know if this works for you. Thanks, Amir. commit 8c2ac6e0cd9d4b01e421375e0b9c3703e774cd9f Author: Amir Goldstein <amir73il@xxxxxxxxx> Date: Sun Apr 12 19:22:19 2020 +0300 Configure custom layers via environment variables The following environment variables are supported: UNIONMOUNT_BASEDIR - parent dir of all samefs layers (default: /base) UNIONMOUNT_LOWERDIR - lower layer path for non samefs (default: /lower) UNIONMOUNT_MNTPOINT - mount point for executing tests (default: /mnt) When user provides paths for base/lower dir, they should point at existing directories and their content will be deleted. When the default base/lower paths are used, tmpfs instances are created. UNIONMOUNT_LOWERDIR is meaningless and will be ignored with --samefs. Empty UNIONMOUNT_LOWERDIR with non-empty UNIONMOUNT_BASEDIR imply --samefs, unless user explicitly requested non samefs setup with maxfs=<M>. This is going to be used for running unionmount tests from xfstests. Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
