On Fri, Apr 10, 2020 at 10:25 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > With index=on, let index dir act as the work dir for copy up and > cleanups. This will help implementing whiteout inode sharing. > > We still create the "work" dir on mount regardless of index=on > and it is used to test the features supported by upper fs. > One reason is that before the feature tests, we do not know if > index could be enabled or not. > > The reason we do not use "index" directory also as workdir with > index=off is because the existence of the "index" directory acts > as a simple persistent signal that index was enabled on this > filesystem and tools may want to use that signal. > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > --- > > Miklos, > > It is worth mentioning that I contemplated about the right point to > overload workdir with indexdir. > > I decided to go for ofs->workdir and not ovl_workdir(), because > it makes the patch touch less code and avoids future uninterntional > uses of ofs->workdir after 'work' dir has been retired. > > That said, I do not feel strongly about it, so I could go for > ovl_workdir() if you prefer. > > I do feel strongly about the decision to keep 'work' dir for > index=off case. Yeah, this looks good. Thanks, Miklos
