On Sun, Apr 12, 2020 at 2:26 PM Eryu Guan <guan@xxxxxxx> wrote: > > On Fri, Apr 10, 2020 at 09:20:59AM +0800, Chengguang Xu wrote: > > This is a test for whiteout inode sharing feature. > > > > Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxxxx> > > --- > > Hi Eryu, > > > > Kernel patch of this feature is still in review but I hope to merge > > If this case tests a new & unmerged feature, I'd wait for the kernel > patch land in first, or at least the maintainer of the subsystem of the > kernel acks that the feature will be in kernel, just that the patch > itself needs some improvements at the moment. > > As there were cases that I merged a case that aimed to test a new > feature or a new behavior, but the kernel patch was dropped eventually, > and the case became broken. > > > test case first, so that we can check the correctness in a convenient > > way. The test case will carefully check new module param and skip the > > test if the param does not exist. > > Or you could provide a personal repo that contains the case, so kernel > maintainers & reviewers could verify the feature with that repo? > FWIW, I am glad the test was posted early for review as a proof of what was tested, but no reason to merge it before the kernel patch. A personal repo link and/or the test in a single patch with the helper should be good enough for reviewers. Thanks, Amir.
