On Tue, Feb 4, 2020 at 7:02 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > On Tue, Feb 4, 2020 at 6:17 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > > > On Tue, Feb 4, 2020 at 3:59 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > > > > > On Fri, Jan 31, 2020 at 12:50:04PM +0100, Miklos Szeredi wrote: > > > > No reason to prevent upper layer being a remote filesystem. Do the > > > > revalidation in that case, just as we already do for lower layers. > > > > > > > > This lets virtiofs be used as upper layer, which appears to be a real use > > > > case. > > > > > > Hi Miklos, > > > > > > I have couple of very basic questions. > > > > > > - So with this change, we will allow NFS to be upper layer also? > > > > I haven't tested, but I think it will fail on the d_type test. > > But we do not fail mount on no d_type support... > Besides, I though you were going to add the RENAME_WHITEOUT > test to avert untested network fs as upper. > Pushed strict remote upper check to: https://github.com/amir73il/linux/commits/ovl-strict-upper FWIW, overlayfs-next+ovl-strict-upper passes the quick xfstests, except for overlay/031 - it fails because the RENAME_WHITEOUT check leaves behind a whiteout in workdir. I think it it is not worth to cleanup that whiteout leftover and easier to fix the test. Thanks, Amir.
