On Mon, Jan 13, 2020 at 4:35 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > On Mon, Jan 13, 2020 at 4:30 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > > > On Sun, Dec 22, 2019 at 9:08 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > > > > Rename lower_fs[] array to fs[], extend its size by one and use > > > index fsid (instead of fsid-1) to access the fs[] array. > > > > > > Initialize fs[0] with upper fs values. fsid 0 is reserved even with > > > lower only overlay, so fs[0] remains null in this case. > > > > > > This gets rid of special casing upper layer in ovl_map_dev_ino(). > > > > Okay, but shouldn't this last one (which changes behavior) be split > > into a separate patch? > > > > Right. > I should probably mention change of behavior in commit message > anyway... > Turns out this change was a mid-series bug and not intentional. ofs->fs[0].pseudo_dev was not even initialized at this point in the series. The last patch in the series in the one changing behavior of upper layer st_dev. I fixed up this problem and the other review comments, tested and and pushed to: https://github.com/amir73il/linux/commits/ovl-layers-v3 Also rebased branch ovl-ino in case you were going to continue on to review the next series. Let me know if you want me to re-post. Thanks, Amir.
