On Sat, Nov 30, 2019 at 01:21:08PM -0800, James Bottomley wrote: > @@ -402,6 +403,10 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap, > > dentry = fhp->fh_dentry; > inode = d_inode(dentry); > + path = &(struct path){ > + .mnt = fhp->fh_export->ex_path.mnt, > + .dentry = dentry, > + }; Is this really clearer than writing: path.mnt = fhp->fh_export->ex_path.mnt; path.dentry = dentry; (there are a few other occurrences I'd change)