On Tue, Oct 29, 2019 at 1:58 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > On Tue, Oct 29, 2019 at 1:17 PM Chengguang Xu <cgxu519@xxxxxxxxxxxx> wrote: > > > > ---- 在 星期二, 2019-10-29 16:32:32 Amir Goldstein <amir73il@xxxxxxxxx> 撰写 ---- > > > On Tue, Oct 29, 2019 at 7:57 AM Chengguang Xu <cgxu519@xxxxxxxxxxxx> wrote: > > > > > > > > > > Can you please send the patch as plain/text. > > > Your mailer has sent it with quoted printable encoding and git am > > > fails to apply the patch: > > > https://lore.kernel.org/fstests/20191029055713.28191-1-cgxu519@xxxxxxxxxxxx/raw > > > > > > > Sorry for that, I'm not clear for the reason, so I send you the patch in attachment first. > > > OK, I can verify that test runs quick (5s) on my VM. But there is one more issue that I think needs to be addressed, either in this fix patch or in a follow up patch. If the test ever fails on some run with a specific random holes sequence, it is going to be quite hard for reporter to report this sequence or for developers to reproduce the same random sequence. One way to fix this is to output the sequence of commands that generated the random files to full output, so it can be used as a recipe for reproducer in case of a failure. If you do that, please make sure that the recipe for creating small random file is clearly separated from recipe for creating big random file. Thanks, Amir.
