---- 在 星期五, 2019-10-25 05:02:07 Amir Goldstein <amir73il@xxxxxxxxx> 撰写 ---- > On Thu, Oct 24, 2019 at 3:29 PM Chengguang Xu <cgxu519@xxxxxxxxxxxx> wrote: > > > > This is intensive copy-up test for sparse files, > > these cases will be mainly used for regression test > > of copy-up improvement for sparse files. > > > > Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> > > Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxxxx> > > > > --- > > v1->v2: > > - Call _get_block_size to get fs block size. > > - Add comment for test space requirement. > > - Print meaningful error message when copy-up fail. > > - Adjust random hole range to 1M~5M. > > - Fix typo. > > > > v2->v3: > > - Fix space requiremnt for test. > > - Add more descriptions for test files and hole patterns. > > - Define well named variables to replace unexplained numbers. > > - Fix random hole algorithm to what Amir suggested. > > - Adjust iosize to start from 1K. > > - Remove from quick test group. > > Why? you said it takes 7s without the kernel patch. > The test overlay/001 is in quick group and it copies up 2*4GB > sparse files. I noticed that after changed to start from 1K iosize the test took about 23s. I'm afraid maybe it will take more time on low performance VM env. The test overlay/001 took 8s/1s with/without kernel patch, so mainly test time wasted on creating test files on test overlay/066. > > Tests that are not in quick group are far less likely to be run > regularly by developers. hmm...well, lets add 'quick' group again and remove it if anyone complains later. Thanks, Chengguang
