Re: [PATCH] overlay/065: adjust test to expect EBUSY only with index=on

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 28, 2019 at 12:04 PM Eryu Guan <guaneryu@xxxxxxxxx> wrote:
>
> On Mon, Jul 22, 2019 at 08:02:27AM +0300, Amir Goldstein wrote:
> > This is needed to support the kernel regression fix commit 0be0bfd2de9d
> > ("ovl: fix regression caused by overlapping layers detection").
> >
> > Overlayfs mount is not supposed to fail due to upper/work dir in-use
> > by other mount unless option index=on is enabled.
>
> Sorry for the late review.. Looks like this patch only mount overlay
> with "index=on" explicitly, but doesn't check that mount succeeds when
> "index=off", which is really regressed. Do we need to add more
> "index=off" tests to ensure we allow re-use upperdir?

Agreed!

Thanks,
Amir.



[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux